feat: add profiles, public views, settings, and code quality fixes
Phase 3 — Profiles & Public Views:
- Public profile page (/u/{username}) with OG meta tags
- User settings page (display name, bio, visibility, default privacy)
- Avatar upload with image processing
- Password change from settings (verifies current password)
- Home page shows public fave feed for logged-in users
- Must-reset-password guard redirects to /reset-password
- Profile visibility: public (full) or limited (username only)
Code quality improvements from /simplify review:
- Fix signup request persistence bug (was silently discarding data)
- Fix health check to use configured listen address, not hardcoded :8080
- Add rate limiter cleanup goroutine (was leaking memory)
- Extract shared helpers: ClearSessionCookie, IsSecureRequest, scanTags,
scanUserFrom (scanner interface), SignupRequestStore
- Replace hand-rolled joinPlaceholders with strings.Join
- Remove dead _method hidden field, redundant devMode field
- Simplify rate-limited route registration (remove double-mux)
- Log previously-swallowed errors (session delete, image delete)
- Stop leaking internal error messages to users in image upload
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
fc1f7259c5
commit
2cbbb20278
9 changed files with 549 additions and 6 deletions
|
|
@ -88,6 +88,23 @@
|
|||
vertical-align: middle;
|
||||
}
|
||||
|
||||
/* Profile header */
|
||||
.profile-header {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 1.5rem;
|
||||
margin-bottom: 1rem;
|
||||
}
|
||||
|
||||
/* Avatar */
|
||||
.avatar-large {
|
||||
width: 120px;
|
||||
height: 120px;
|
||||
border-radius: 50%;
|
||||
object-fit: cover;
|
||||
flex-shrink: 0;
|
||||
}
|
||||
|
||||
/* Tag chips */
|
||||
.tag-chip {
|
||||
display: inline-block;
|
||||
|
|
|
|||
|
|
@ -1,10 +1,59 @@
|
|||
{{define "content"}}
|
||||
<hgroup>
|
||||
<h1>Velkommen til {{.SiteName}}</h1>
|
||||
<p>Del dine favoritter med verden — eller behold dem for deg selv.</p>
|
||||
</hgroup>
|
||||
{{if .User}}
|
||||
<hgroup>
|
||||
<h1>Siste offentlige favoritter</h1>
|
||||
<p>Se hva folk deler</p>
|
||||
</hgroup>
|
||||
|
||||
{{if not .User}}
|
||||
{{with .Data}}
|
||||
{{if .Faves}}
|
||||
<div class="fave-grid" role="list">
|
||||
{{range .Faves}}
|
||||
<article class="fave-card" role="listitem">
|
||||
{{if .ImagePath}}
|
||||
<img src="{{basePath}}/uploads/{{.ImagePath}}"
|
||||
alt="Bilde for: {{.Description}}"
|
||||
loading="lazy">
|
||||
{{end}}
|
||||
<header>
|
||||
<a href="{{basePath}}/faves/{{.ID}}">
|
||||
<strong>{{.Description}}</strong>
|
||||
</a>
|
||||
<small>av <a href="{{basePath}}/u/{{.Username}}">{{.DisplayName}}</a></small>
|
||||
</header>
|
||||
{{if .Tags}}
|
||||
<footer>
|
||||
{{range .Tags}}
|
||||
<a href="{{basePath}}/tags/{{.Name}}" class="tag-chip">{{.Name}}</a>
|
||||
{{end}}
|
||||
</footer>
|
||||
{{end}}
|
||||
</article>
|
||||
{{end}}
|
||||
</div>
|
||||
|
||||
{{if gt .TotalPages 1}}
|
||||
<nav aria-label="Sidenavigasjon">
|
||||
<ul>
|
||||
{{if gt .Page 1}}
|
||||
<li><a href="{{basePath}}/?page={{subtract .Page 1}}">← Forrige</a></li>
|
||||
{{end}}
|
||||
<li>Side {{.Page}} av {{.TotalPages}}</li>
|
||||
{{if lt .Page .TotalPages}}
|
||||
<li><a href="{{basePath}}/?page={{add .Page 1}}">Neste →</a></li>
|
||||
{{end}}
|
||||
</ul>
|
||||
</nav>
|
||||
{{end}}
|
||||
{{else}}
|
||||
<p>Ingen offentlige favoritter ennå. <a href="{{basePath}}/faves/new">Legg til din første!</a></p>
|
||||
{{end}}
|
||||
{{end}}
|
||||
{{else}}
|
||||
<hgroup>
|
||||
<h1>Velkommen til {{.SiteName}}</h1>
|
||||
<p>Del dine favoritter med verden — eller behold dem for deg selv.</p>
|
||||
</hgroup>
|
||||
<div class="grid">
|
||||
<a href="{{basePath}}/login" role="button">Logg inn</a>
|
||||
<a href="{{basePath}}/signup" role="button" class="outline">Registrer deg</a>
|
||||
|
|
|
|||
106
web/templates/pages/profile.html
Normal file
106
web/templates/pages/profile.html
Normal file
|
|
@ -0,0 +1,106 @@
|
|||
{{define "head"}}
|
||||
{{with .Data}}{{with .ProfileUser}}
|
||||
{{if eq .ProfileVisibility "public"}}
|
||||
<meta property="og:title" content="{{.DisplayNameOrUsername}} sine favoritter">
|
||||
<meta property="og:type" content="profile">
|
||||
{{if $.ExternalURL}}
|
||||
<meta property="og:url" content="{{$.ExternalURL}}/u/{{.Username}}">
|
||||
{{if .AvatarPath}}
|
||||
<meta property="og:image" content="{{$.ExternalURL}}/uploads/{{.AvatarPath}}">
|
||||
{{end}}
|
||||
{{end}}
|
||||
<meta property="og:site_name" content="{{$.SiteName}}">
|
||||
{{end}}
|
||||
{{end}}{{end}}
|
||||
{{end}}
|
||||
|
||||
{{define "content"}}
|
||||
{{with .Data}}
|
||||
{{with .ProfileUser}}
|
||||
<section class="profile-header">
|
||||
{{if .AvatarPath}}
|
||||
<img src="{{basePath}}/uploads/{{.AvatarPath}}"
|
||||
alt="Profilbilde for {{.DisplayNameOrUsername}}"
|
||||
class="avatar-large">
|
||||
{{end}}
|
||||
<hgroup>
|
||||
<h1>{{.DisplayNameOrUsername}}</h1>
|
||||
{{if and (ne .DisplayName "") (ne .DisplayName .Username)}}
|
||||
<p>@{{.Username}}</p>
|
||||
{{end}}
|
||||
</hgroup>
|
||||
</section>
|
||||
|
||||
{{if not $.IsLimited}}
|
||||
{{if .Bio}}
|
||||
<p>{{.Bio}}</p>
|
||||
{{end}}
|
||||
|
||||
<p><small>Medlem siden {{.CreatedAt.Format "02.01.2006"}}</small></p>
|
||||
|
||||
{{if $.IsOwner}}
|
||||
<p>
|
||||
<a href="{{basePath}}/settings" role="button" class="outline">Rediger profil</a>
|
||||
<a href="{{basePath}}/faves/new" role="button">+ Ny favoritt</a>
|
||||
</p>
|
||||
{{end}}
|
||||
|
||||
<h2>
|
||||
{{if $.IsOwner}}Favoritter{{else}}Offentlige favoritter{{end}}
|
||||
<small>({{$.Total}})</small>
|
||||
</h2>
|
||||
|
||||
{{if $.Faves}}
|
||||
<div class="fave-grid" role="list">
|
||||
{{range $.Faves}}
|
||||
<article class="fave-card" role="listitem">
|
||||
{{if .ImagePath}}
|
||||
<img src="{{basePath}}/uploads/{{.ImagePath}}"
|
||||
alt="Bilde for: {{.Description}}"
|
||||
loading="lazy">
|
||||
{{end}}
|
||||
<header>
|
||||
<a href="{{basePath}}/faves/{{.ID}}">
|
||||
<strong>{{.Description}}</strong>
|
||||
</a>
|
||||
{{if eq .Privacy "private"}}
|
||||
<small class="badge-private" aria-label="Privat">Privat</small>
|
||||
{{end}}
|
||||
</header>
|
||||
{{if .Tags}}
|
||||
<footer>
|
||||
{{range .Tags}}
|
||||
<a href="{{basePath}}/tags/{{.Name}}" class="tag-chip">{{.Name}}</a>
|
||||
{{end}}
|
||||
</footer>
|
||||
{{end}}
|
||||
</article>
|
||||
{{end}}
|
||||
</div>
|
||||
|
||||
{{if gt $.TotalPages 1}}
|
||||
<nav aria-label="Sidenavigasjon">
|
||||
<ul>
|
||||
{{if gt $.Page 1}}
|
||||
<li><a href="{{basePath}}/u/{{.Username}}?page={{subtract $.Page 1}}">← Forrige</a></li>
|
||||
{{end}}
|
||||
<li>Side {{$.Page}} av {{$.TotalPages}}</li>
|
||||
{{if lt $.Page $.TotalPages}}
|
||||
<li><a href="{{basePath}}/u/{{.Username}}?page={{add $.Page 1}}">Neste →</a></li>
|
||||
{{end}}
|
||||
</ul>
|
||||
</nav>
|
||||
{{end}}
|
||||
{{else}}
|
||||
{{if $.IsOwner}}
|
||||
<p>Du har ingen favoritter ennå. <a href="{{basePath}}/faves/new">Legg til din første!</a></p>
|
||||
{{else}}
|
||||
<p>Ingen offentlige favoritter ennå.</p>
|
||||
{{end}}
|
||||
{{end}}
|
||||
{{else}}
|
||||
<p><small>Denne profilen har begrenset synlighet.</small></p>
|
||||
{{end}}
|
||||
{{end}}
|
||||
{{end}}
|
||||
{{end}}
|
||||
95
web/templates/pages/settings.html
Normal file
95
web/templates/pages/settings.html
Normal file
|
|
@ -0,0 +1,95 @@
|
|||
{{define "head"}}
|
||||
<meta name="robots" content="noindex">
|
||||
{{end}}
|
||||
|
||||
{{define "content"}}
|
||||
{{with .Data}}{{with .SettingsUser}}
|
||||
<h1>Innstillinger</h1>
|
||||
|
||||
<article>
|
||||
<h2>Profil</h2>
|
||||
<form method="POST" action="{{basePath}}/settings">
|
||||
<input type="hidden" name="csrf_token" value="{{$.CSRFToken}}">
|
||||
<label for="display_name">
|
||||
Visningsnavn
|
||||
<input type="text" id="display_name" name="display_name"
|
||||
value="{{.DisplayName}}" maxlength="50"
|
||||
placeholder="Vises i stedet for brukernavnet">
|
||||
</label>
|
||||
<label for="bio">
|
||||
Om meg
|
||||
<textarea id="bio" name="bio" rows="3" maxlength="500"
|
||||
placeholder="Kort om deg selv">{{.Bio}}</textarea>
|
||||
</label>
|
||||
<fieldset>
|
||||
<legend>Profilsynlighet</legend>
|
||||
<label>
|
||||
<input type="radio" name="profile_visibility" value="public"
|
||||
{{if eq .ProfileVisibility "public"}}checked{{end}}>
|
||||
Offentlig — visningsnavn, bio og favoritter synlig for alle
|
||||
</label>
|
||||
<label>
|
||||
<input type="radio" name="profile_visibility" value="limited"
|
||||
{{if eq .ProfileVisibility "limited"}}checked{{end}}>
|
||||
Begrenset — bare brukernavn synlig
|
||||
</label>
|
||||
</fieldset>
|
||||
<fieldset>
|
||||
<legend>Standard synlighet for nye favoritter</legend>
|
||||
<label>
|
||||
<input type="radio" name="default_fave_privacy" value="public"
|
||||
{{if eq .DefaultFavePrivacy "public"}}checked{{end}}>
|
||||
Offentlig
|
||||
</label>
|
||||
<label>
|
||||
<input type="radio" name="default_fave_privacy" value="private"
|
||||
{{if eq .DefaultFavePrivacy "private"}}checked{{end}}>
|
||||
Privat
|
||||
</label>
|
||||
</fieldset>
|
||||
<button type="submit">Lagre profil</button>
|
||||
</form>
|
||||
</article>
|
||||
|
||||
<article>
|
||||
<h2>Profilbilde</h2>
|
||||
{{if .AvatarPath}}
|
||||
<img src="{{basePath}}/uploads/{{.AvatarPath}}"
|
||||
alt="Nåværende profilbilde"
|
||||
class="avatar-large">
|
||||
{{end}}
|
||||
<form method="POST" action="{{basePath}}/settings/avatar" enctype="multipart/form-data">
|
||||
<input type="hidden" name="csrf_token" value="{{$.CSRFToken}}">
|
||||
<label for="avatar">
|
||||
Last opp nytt profilbilde
|
||||
<input type="file" id="avatar" name="avatar"
|
||||
accept="image/jpeg,image/png,image/gif,image/webp">
|
||||
</label>
|
||||
<button type="submit">Last opp</button>
|
||||
</form>
|
||||
</article>
|
||||
|
||||
<article>
|
||||
<h2>Endre passord</h2>
|
||||
<form method="POST" action="{{basePath}}/settings/password">
|
||||
<input type="hidden" name="csrf_token" value="{{$.CSRFToken}}">
|
||||
<label for="current_password">
|
||||
Nåværende passord
|
||||
<input type="password" id="current_password" name="current_password" required
|
||||
autocomplete="current-password">
|
||||
</label>
|
||||
<label for="new_password">
|
||||
Nytt passord
|
||||
<input type="password" id="new_password" name="new_password" required
|
||||
autocomplete="new-password" minlength="8">
|
||||
</label>
|
||||
<label for="confirm_password">
|
||||
Bekreft nytt passord
|
||||
<input type="password" id="confirm_password" name="confirm_password" required
|
||||
autocomplete="new-password">
|
||||
</label>
|
||||
<button type="submit">Endre passord</button>
|
||||
</form>
|
||||
</article>
|
||||
{{end}}{{end}}
|
||||
{{end}}
|
||||
Loading…
Add table
Add a link
Reference in a new issue