olemd/skyview
1
0
Fork 0
Code Issues 12 Pull requests Projects Releases 11 Packages Wiki Activity Actions

Fix aircraft track propagation issues in web frontend

Browse source 
This commit addresses issue #23 where aircraft track changes were not
propagating properly to the web frontend. The fixes include:

**Server-side improvements:**
- Enhanced WebSocket broadcast reliability with timeout-based queueing
- Increased broadcast channel buffer size (1000 -> 2000)
- Improved error handling and connection management
- Added write timeouts to prevent slow clients from blocking updates
- Enhanced connection cleanup and ping/pong handling
- Added debug endpoint /api/debug/websocket for troubleshooting
- Relaxed position validation thresholds for better track acceptance

**Frontend improvements:**
- Enhanced WebSocket manager with exponential backoff reconnection
- Improved aircraft position update detection and logging
- Fixed position update logic to always propagate changes to map
- Better coordinate validation and error reporting
- Enhanced debugging with detailed console logging
- Fixed track rotation update thresholds and logic
- Improved marker lifecycle management and cleanup
- Better handling of edge cases in aircraft state transitions

**Key bug fixes:**
- Removed overly aggressive position change detection that blocked updates
- Fixed track rotation sensitivity (5° -> 10° threshold)
- Enhanced coordinate validation to handle null/undefined values
- Improved WebSocket message ordering and processing
- Fixed marker position updates to always propagate to Leaflet

These changes ensure reliable real-time aircraft tracking with proper
position, heading, and altitude updates across multiple data sources.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Ole-Morten Duesund 2025-08-25 10:14:03 +02:00
commit 1fe15c06a3
6 changed files with 216 additions and 49 deletions
Download patch file Download diff file Expand all files Collapse all files

70
assets/static/js/modules/aircraft-manager.js
View file

@ -79,15 +79,45 @@ export class AircraftManager {
updateAircraftData(data) {
if (data.aircraft) {
// Track which aircraft are new or have position changes for debugging
let newCount = 0;
let updatedCount = 0;
let positionChanges = 0;
// Clear old data and update with new data
const previousData = new Map(this.aircraftData);
this.aircraftData.clear();
for (const [icao, aircraft] of Object.entries(data.aircraft)) {
const previousAircraft = previousData.get(icao);
if (!previousAircraft) {
newCount++;
} else {
updatedCount++;
// Check for position changes
if (previousAircraft.Latitude !== aircraft.Latitude ||
previousAircraft.Longitude !== aircraft.Longitude ||
previousAircraft.Track !== aircraft.Track ||
previousAircraft.Altitude !== aircraft.Altitude) {
positionChanges++;
}
}
this.aircraftData.set(icao, aircraft);
}
// Debug logging for track propagation issues
if (newCount > 0 || positionChanges > 0) {
console.debug(`Aircraft update: ${newCount} new, ${updatedCount} updated, ${positionChanges} position changes`);
}
}
}
updateMarkers() {
if (!this.map) {
console.debug("Map not available for updateMarkers");
return;
}
@ -114,19 +144,29 @@ export class AircraftManager {
}
this.markerRemoveCount++;
console.debug(`Removed stale aircraft marker: ${icao}`);
}
}
// Update aircraft markers - only for aircraft with valid geographic coordinates
// Update aircraft markers - process ALL aircraft, not just those with valid coordinates yet
// Let updateAircraftMarker handle coordinate validation
for (const [icao, aircraft] of this.aircraftData) {
const hasCoords = aircraft.Latitude && aircraft.Longitude && aircraft.Latitude !== 0 && aircraft.Longitude !== 0;
// More comprehensive coordinate check
const hasCoords = aircraft.Latitude != null && aircraft.Longitude != null &&
aircraft.Latitude !== 0 && aircraft.Longitude !== 0;
const validLat = aircraft.Latitude >= -90 && aircraft.Latitude <= 90;
const validLng = aircraft.Longitude >= -180 && aircraft.Longitude <= 180;
if (hasCoords && validLat && validLng) {
this.updateAircraftMarker(icao, aircraft);
} else if (hasCoords) {
// Log invalid coordinates for debugging
console.debug(`Invalid coordinates for ${icao}: lat=${aircraft.Latitude}, lng=${aircraft.Longitude}`);
}
// If no coordinates, we still want to process for other updates (trails, etc.)
}
console.debug(`Markers update complete: ${this.aircraftMarkers.size} active markers, ${this.aircraftData.size} aircraft`);
}
updateAircraftMarker(icao, aircraft) {
@ -146,25 +186,43 @@ export class AircraftManager {
// Update existing marker - KISS approach
const marker = this.aircraftMarkers.get(icao);
// Always update position - let Leaflet handle everything
// Always update position - don't try to be too smart about detecting changes
const oldPos = marker.getLatLng();
const positionChanged = Math.abs(oldPos.lat - pos[0]) > 0.0001 || Math.abs(oldPos.lng - pos[1]) > 0.0001;
// ALWAYS update position regardless of change detection to ensure propagation
marker.setLatLng(pos);
if (positionChanged) {
// Debug significant position updates
console.debug(`Position change for ${icao}: [${pos[0].toFixed(4)}, ${pos[1].toFixed(4)}] (was [${oldPos.lat.toFixed(4)}, ${oldPos.lng.toFixed(4)}])`);
}
// Check if icon needs to be updated (track rotation, aircraft type, or ground status changes)
const currentRotation = marker._currentRotation || 0;
const currentType = marker._currentType || null;
const currentOnGround = marker._currentOnGround || false;
const newType = this.getAircraftIconType(aircraft);
const rotationChanged = aircraft.Track !== undefined && Math.abs(currentRotation - aircraft.Track) > 5;
// Fix rotation change detection - handle undefined/null tracks properly
const newTrack = aircraft.Track || 0;
const rotationChanged = aircraft.Track !== undefined && aircraft.Track !== null &&
Math.abs(currentRotation - newTrack) > 10; // Increased threshold
const typeChanged = currentType !== newType;
const groundStatusChanged = currentOnGround !== aircraft.OnGround;
if (rotationChanged || typeChanged || groundStatusChanged) {
// Update icon if anything changed, OR if this is a new track value and we didn't have one before
const firstTrackUpdate = currentRotation === 0 && aircraft.Track !== undefined && aircraft.Track !== null && aircraft.Track !== 0;
if (rotationChanged || typeChanged || groundStatusChanged || firstTrackUpdate) {
marker.setIcon(this.createAircraftIcon(aircraft));
marker._currentRotation = aircraft.Track || 0;
marker._currentRotation = newTrack;
marker._currentType = newType;
marker._currentOnGround = aircraft.OnGround || false;
if (rotationChanged || firstTrackUpdate) {
console.debug(`Updated track for ${icao}: ${aircraft.Track}° (was ${currentRotation}°)`);
}
}
// Handle popup exactly like Leaflet expects