From 5c33bdacd2216939d769eee73d805a64b6f89b4a Mon Sep 17 00:00:00 2001
From: Ole-Morten Duesund <olemd@glemt.net>
Date: Sat, 23 Aug 2025 22:43:25 +0200
Subject: [PATCH] Fix Chart.js loading and add favicon support
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Switch from chart.min.js to chart.umd.js for proper module loading
- Add favicon.ico file and proper serving
- Add favicon link in HTML head to prevent 404 errors

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 internal/server/server.go | 9 ++++++++-
 static/favicon.ico        | 1 +
 static/index.html         | 3 ++-
 3 files changed, 11 insertions(+), 2 deletions(-)
 create mode 100644 static/favicon.ico

diff --git a/internal/server/server.go b/internal/server/server.go
index 8b396d7..6e311df 100644
--- a/internal/server/server.go
+++ b/internal/server/server.go
@@ -81,8 +81,15 @@ func (s *Server) serveIndex(w http.ResponseWriter, r *http.Request) {
 }
 
 func (s *Server) serveFavicon(w http.ResponseWriter, r *http.Request) {
+	data, err := s.staticFiles.ReadFile("static/favicon.ico")
+	if err != nil {
+		w.Header().Set("Content-Type", "image/x-icon")
+		w.WriteHeader(http.StatusNotFound)
+		return
+	}
+
 	w.Header().Set("Content-Type", "image/x-icon")
-	w.WriteHeader(http.StatusNotFound)
+	w.Write(data)
 }
 
 func (s *Server) getAircraft(w http.ResponseWriter, r *http.Request) {
diff --git a/static/favicon.ico b/static/favicon.ico
new file mode 100644
index 0000000..a0f2003
--- /dev/null
+++ b/static/favicon.ico
@@ -0,0 +1 @@
+data:image/x-icon;base64,AAABAAEAEBAAAAEAIABoBAAAFgAAACgAAAAQAAAAIAAAAAEAIAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
\ No newline at end of file
diff --git a/static/index.html b/static/index.html
index 8028721..370cc23 100644
--- a/static/index.html
+++ b/static/index.html
@@ -4,6 +4,7 @@
     <meta charset="UTF-8">
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
     <title>SkyView - ADS-B Aircraft Tracker</title>
+    <link rel="icon" type="image/x-icon" href="/favicon.ico">
     <link rel="stylesheet" href="https://unpkg.com/leaflet@1.9.4/dist/leaflet.css" />
     <link rel="stylesheet" href="/static/css/style.css">
 </head>
@@ -96,7 +97,7 @@
     </div>
 
     <script src="https://unpkg.com/leaflet@1.9.4/dist/leaflet.js"></script>
-    <script src="https://cdn.jsdelivr.net/npm/chart.js@4.4.0/dist/chart.min.js"></script>
+    <script src="https://cdn.jsdelivr.net/npm/chart.js@4.4.0/dist/chart.umd.js"></script>
     <script src="/static/js/app.js"></script>
 </body>
 </html>
\ No newline at end of file